Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

test: Move OS version tests to common.js#63

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:aix_osversion
Closed

test: Move OS version tests to common.js#63
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:aix_osversion

Conversation

@richardlau

Copy link
Copy Markdown
Member

See #57 (comment).

Moves the OS version tests from a separate test file to common.js so it is validated each time a report is validated by a test.

@richardlau

Copy link
Copy Markdown
Member Author

At some point we might want to break validateContent() into smaller functions (perhaps validateReportHeader, validateSystemInfo, etc.) -- Although this will make totaling the expected number of tests trickier.

@rnchamberlain

Copy link
Copy Markdown
Contributor

LGTM, and I ran a CI on it:
https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/100/
needs a rebase though

@richardlau

Copy link
Copy Markdown
Member Author

@richardlau

Copy link
Copy Markdown
Member Author

CI failed on Windows to download a Node runtime. Raised #66.
Also failed on AIX: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/109/MACHINE=aix61-ppc64/console

# Subtest: test/test-fatal-error.js
    1..0
not ok 9 - test/test-fatal-error.js # time=30022.646ms
  ---
  timeout: 30000
  file: test/test-fatal-error.js
  failure: timeout
  results:
    ok: false
    count: 0
    pass: 0
    plan:
      start: 1
      end: 0
      skipAll: true
  signal: SIGTERM
  command: >-
    /home/iojs/build/workspace/nodereport-continuous-integration/MACHINE/aix61-ppc64/node-v8.0.0-nightly2017030187a039d721-aix-ppc64/bin/node
  arguments:
    - test/test-fatal-error.js
  ...

@rnchamberlain

Copy link
Copy Markdown
Contributor

I think I've seen the AIX failure before. I'd have thought that 30 secs would be plenty of time to fill the 20Mb heap, but maybe the machine is very slow (it does seem to be by far the slowest platform to run in the CI).

@mhdawson

mhdawson commented Mar 6, 2017

Copy link
Copy Markdown
Member

@rnchamberlain if you think there is a flaky test can you open an issue for it so that it gets investigated ?

@mhdawson

mhdawson commented Mar 6, 2017

Copy link
Copy Markdown
Member

I opened an issue for an AIX failure as I ran on master and it there was a failure so it may be persistent as opposed to flaky: #69

@hhellyer

hhellyer commented Mar 9, 2017

Copy link
Copy Markdown
Contributor

LGTM

rnchamberlain pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #63
Reviewed-By: Richard Chamberlain <richard_chamberlain@uk.ibm.com>
Reviewed-By: Howard Hellyer <hhellyer@uk.ibm.com>
@rnchamberlain

Copy link
Copy Markdown
Contributor

Landed as 918ef91

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants